mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 18:51:29 +00:00
tests: switch to 4 space indent
Reformat this dir by itself to help merging with conflicts with other CLs. Reformatted using: parallel ./yapf -i -- tests/*.py ~/chromiumos/chromite/contrib/reflow_overlong_comments tests/*.py These files still had lines (strings) that were too long, so the pylint warnings were suppressed with a TODO. tests/bot_update_coverage_test.py tests/cipd_bootstrap_test.py tests/gclient_eval_unittest.py tests/gclient_git_smoketest.py tests/gclient_scm_test.py tests/gclient_smoketest.py tests/gclient_test.py tests/gclient_transitions_smoketest.py tests/gclient_utils_test.py tests/git_cl_test.py tests/git_hyper_blame_test.py tests/git_rebase_update_test.py tests/lockfile_test.py tests/metrics_test.py tests/presubmit_canned_checks_test.py tests/presubmit_unittest.py tests/roll_dep_test.py Change-Id: I8fed04b4ba81d54b8f45da612213aad27a9e1a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4842592 Commit-Queue: Josip Sokcevic <sokcevic@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Auto-Submit: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
Mike Frysinger
@@ -16,150 +16,166 @@ import ninjalog_uploader
|
||||
|
||||
|
||||
class NinjalogUploaderTest(unittest.TestCase):
|
||||
def test_IsGoogler(self):
|
||||
with unittest.mock.patch('subprocess.run') as run_mock:
|
||||
run_mock.return_value.returncode = 0
|
||||
run_mock.return_value.stdout = ('Login as foo@google.com\n'
|
||||
'goma is ready to use')
|
||||
self.assertTrue(ninjalog_uploader.IsGoogler())
|
||||
def test_IsGoogler(self):
|
||||
with unittest.mock.patch('subprocess.run') as run_mock:
|
||||
run_mock.return_value.returncode = 0
|
||||
run_mock.return_value.stdout = ('Login as foo@google.com\n'
|
||||
'goma is ready to use')
|
||||
self.assertTrue(ninjalog_uploader.IsGoogler())
|
||||
|
||||
with unittest.mock.patch('subprocess.run') as run_mock:
|
||||
run_mock.return_value.returncode = 1
|
||||
self.assertFalse(ninjalog_uploader.IsGoogler())
|
||||
with unittest.mock.patch('subprocess.run') as run_mock:
|
||||
run_mock.return_value.returncode = 1
|
||||
self.assertFalse(ninjalog_uploader.IsGoogler())
|
||||
|
||||
with unittest.mock.patch('subprocess.run') as run_mock:
|
||||
run_mock.return_value.returncode = 0
|
||||
run_mock.return_value.stdout = ''
|
||||
self.assertFalse(ninjalog_uploader.IsGoogler())
|
||||
with unittest.mock.patch('subprocess.run') as run_mock:
|
||||
run_mock.return_value.returncode = 0
|
||||
run_mock.return_value.stdout = ''
|
||||
self.assertFalse(ninjalog_uploader.IsGoogler())
|
||||
|
||||
with unittest.mock.patch('subprocess.run') as run_mock:
|
||||
run_mock.return_value.returncode = 0
|
||||
run_mock.return_value.stdout = 'Login as foo@example.com\n'
|
||||
self.assertFalse(ninjalog_uploader.IsGoogler())
|
||||
with unittest.mock.patch('subprocess.run') as run_mock:
|
||||
run_mock.return_value.returncode = 0
|
||||
run_mock.return_value.stdout = 'Login as foo@example.com\n'
|
||||
self.assertFalse(ninjalog_uploader.IsGoogler())
|
||||
|
||||
def test_parse_gn_args(self):
|
||||
self.assertEqual(ninjalog_uploader.ParseGNArgs(json.dumps([])), {})
|
||||
def test_parse_gn_args(self):
|
||||
self.assertEqual(ninjalog_uploader.ParseGNArgs(json.dumps([])), {})
|
||||
|
||||
# Extract current configs from GN's output json.
|
||||
self.assertEqual(ninjalog_uploader.ParseGNArgs(json.dumps([
|
||||
{
|
||||
'current': {'value': 'true'},
|
||||
'default': {'value': 'false'},
|
||||
'name': 'is_component_build'
|
||||
},
|
||||
{
|
||||
'default': {'value': '"x64"'},
|
||||
'name': 'host_cpu'
|
||||
},
|
||||
])), {
|
||||
'is_component_build': 'true',
|
||||
'host_cpu': '"x64"',
|
||||
})
|
||||
# Extract current configs from GN's output json.
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.ParseGNArgs(
|
||||
json.dumps([
|
||||
{
|
||||
'current': {
|
||||
'value': 'true'
|
||||
},
|
||||
'default': {
|
||||
'value': 'false'
|
||||
},
|
||||
'name': 'is_component_build'
|
||||
},
|
||||
{
|
||||
'default': {
|
||||
'value': '"x64"'
|
||||
},
|
||||
'name': 'host_cpu'
|
||||
},
|
||||
])), {
|
||||
'is_component_build': 'true',
|
||||
'host_cpu': '"x64"',
|
||||
})
|
||||
|
||||
self.assertEqual(ninjalog_uploader.ParseGNArgs(json.dumps([
|
||||
{
|
||||
'current': {'value': 'true'},
|
||||
'default': {'value': 'false'},
|
||||
'name': 'is_component_build'
|
||||
},
|
||||
{
|
||||
'current': {'value': 'false'},
|
||||
'default': {'value': 'false'},
|
||||
'name': 'use_goma'
|
||||
},
|
||||
])), {'is_component_build': 'true',
|
||||
'use_goma': 'false'})
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.ParseGNArgs(
|
||||
json.dumps([
|
||||
{
|
||||
'current': {
|
||||
'value': 'true'
|
||||
},
|
||||
'default': {
|
||||
'value': 'false'
|
||||
},
|
||||
'name': 'is_component_build'
|
||||
},
|
||||
{
|
||||
'current': {
|
||||
'value': 'false'
|
||||
},
|
||||
'default': {
|
||||
'value': 'false'
|
||||
},
|
||||
'name': 'use_goma'
|
||||
},
|
||||
])), {
|
||||
'is_component_build': 'true',
|
||||
'use_goma': 'false'
|
||||
})
|
||||
|
||||
def test_get_ninjalog(self):
|
||||
# No args => default to cwd.
|
||||
self.assertEqual(ninjalog_uploader.GetNinjalog(['ninja']),
|
||||
'./.ninja_log')
|
||||
def test_get_ninjalog(self):
|
||||
# No args => default to cwd.
|
||||
self.assertEqual(ninjalog_uploader.GetNinjalog(['ninja']),
|
||||
'./.ninja_log')
|
||||
|
||||
# Specified by -C case.
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetNinjalog(['ninja', '-C', 'out/Release']),
|
||||
'out/Release/.ninja_log')
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetNinjalog(['ninja', '-Cout/Release']),
|
||||
'out/Release/.ninja_log')
|
||||
# Specified by -C case.
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetNinjalog(['ninja', '-C', 'out/Release']),
|
||||
'out/Release/.ninja_log')
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetNinjalog(['ninja', '-Cout/Release']),
|
||||
'out/Release/.ninja_log')
|
||||
|
||||
# Invalid -C flag case.
|
||||
self.assertEqual(ninjalog_uploader.GetNinjalog(['ninja', '-C']),
|
||||
'./.ninja_log')
|
||||
# Invalid -C flag case.
|
||||
self.assertEqual(ninjalog_uploader.GetNinjalog(['ninja', '-C']),
|
||||
'./.ninja_log')
|
||||
|
||||
# Multiple target directories => use the last directory.
|
||||
self.assertEqual(ninjalog_uploader.GetNinjalog(
|
||||
['ninja', '-C', 'out/Release', '-C', 'out/Debug']),
|
||||
'out/Debug/.ninja_log')
|
||||
# Multiple target directories => use the last directory.
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetNinjalog(
|
||||
['ninja', '-C', 'out/Release', '-C', 'out/Debug']),
|
||||
'out/Debug/.ninja_log')
|
||||
|
||||
def test_get_build_target_from_command_line(self):
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', 'chrome']), ['chrome'])
|
||||
def test_get_build_target_from_command_line(self):
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', 'chrome']), ['chrome'])
|
||||
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(['python3',
|
||||
'ninja.py']), [])
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py']), [])
|
||||
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', '-j', '1000', 'chrome']), ['chrome'])
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', '-j', '1000', 'chrome']), ['chrome'])
|
||||
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', 'chrome', '-j', '1000']), ['chrome'])
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', 'chrome', '-j', '1000']), ['chrome'])
|
||||
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', '-C', 'chrome']), [])
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', '-C', 'chrome']), [])
|
||||
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', '-Cout/Release', 'chrome']), ['chrome'])
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', '-Cout/Release', 'chrome']), ['chrome'])
|
||||
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', '-C', 'out/Release', 'chrome', 'all']),
|
||||
['chrome', 'all'])
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine(
|
||||
['python3', 'ninja.py', '-C', 'out/Release', 'chrome', 'all']),
|
||||
['chrome', 'all'])
|
||||
|
||||
@unittest.skipIf(sys.platform == 'win32', 'posix path test')
|
||||
def test_get_build_target_from_command_line_filter_posix(self):
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine([
|
||||
'python3', 'ninja.py', '-C', 'out/Release', 'chrome', 'all',
|
||||
'/path/to/foo', '-p'
|
||||
]), ['chrome', 'all'])
|
||||
@unittest.skipIf(sys.platform == 'win32', 'posix path test')
|
||||
def test_get_build_target_from_command_line_filter_posix(self):
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine([
|
||||
'python3', 'ninja.py', '-C', 'out/Release', 'chrome', 'all',
|
||||
'/path/to/foo', '-p'
|
||||
]), ['chrome', 'all'])
|
||||
|
||||
@unittest.skipUnless(sys.platform == 'win32', 'Windows path test')
|
||||
def test_get_build_target_from_command_line_filter_win(self):
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine([
|
||||
'python3', 'ninja.py', '-C', 'out/Release', 'chrome', 'all',
|
||||
'C:\\path\\to\\foo', '-p'
|
||||
]), ['chrome', 'all'])
|
||||
@unittest.skipUnless(sys.platform == 'win32', 'Windows path test')
|
||||
def test_get_build_target_from_command_line_filter_win(self):
|
||||
self.assertEqual(
|
||||
ninjalog_uploader.GetBuildTargetFromCommandLine([
|
||||
'python3', 'ninja.py', '-C', 'out/Release', 'chrome', 'all',
|
||||
'C:\\path\\to\\foo', '-p'
|
||||
]), ['chrome', 'all'])
|
||||
|
||||
def test_get_j_flag(self):
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(
|
||||
['ninja']), None)
|
||||
def test_get_j_flag(self):
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(['ninja']), None)
|
||||
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(
|
||||
['ninja','-j', '1000']), 1000)
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(['ninja', '-j', '1000']),
|
||||
1000)
|
||||
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(
|
||||
['ninja','-j', '1000a']), None)
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(['ninja', '-j', '1000a']),
|
||||
None)
|
||||
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(
|
||||
['ninja','-j', 'a']), None)
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(['ninja', '-j', 'a']), None)
|
||||
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(
|
||||
['ninja','-j1000']), 1000)
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(['ninja', '-j1000']), 1000)
|
||||
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(
|
||||
['ninja','-ja']), None)
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(['ninja', '-ja']), None)
|
||||
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(
|
||||
['ninja','-j']), None)
|
||||
self.assertEqual(ninjalog_uploader.GetJflag(['ninja', '-j']), None)
|
||||
|
||||
|
||||
if __name__ == '__main__':
|
||||
unittest.main()
|
||||
unittest.main()
|
||||
|
||||
Reference in New Issue
Block a user