InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

git-cache: contains_revision returns False if sentient file exists

Browse Source 
If git_cache.populate() gets interrupted midway, it can possibly leave
a git mirror in a state where only some commits are available. Cloning
such a repo results in an empty repository and causes subsequent git
checkout to fail.

If the sentient file exists, it indicates that the bootstrapping
process was interrupted. This CL updates git_cache.contains_revision()
such that it returns False if the sentient file exists. Then,
the caller can call mirror.populate() to re-populate the repo/rev.

Bug: 41488725
Change-Id: I24fd24e300f5a9f9349589496d6b5f3dacf71fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6491733
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
This commit is contained in:
Scott Lee
2025-04-28 10:47:52 -07:00
committed by LUCI CQ
parent 2f575c52fc
commit 5a267a66a6
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
git_cache.py
View File

@@ -317,6 +317,14 @@ class Mirror(object):
if not self.exists(): if not self.exists():
return False return False
# If the cache population is in progress, this will raise LockError().
with lockfile.lock(self.mirror_path, timeout=0):
# If the sentinent file exists at this point, it indicates that
# the bootstrapping process was interrupted, leaving the cache
# entries in a bad state.
if os.path.isfile(self._init_sentient_file):
return False
if sys.platform.startswith('win'): if sys.platform.startswith('win'):
# Windows .bat scripts use ^ as escape sequence, which means we have # Windows .bat scripts use ^ as escape sequence, which means we have
# to escape it with itself for every .bat invocation. # to escape it with itself for every .bat invocation.