InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

siso: for post_build_ninja_summary.py convert every long flag to be double dashed.

Browse Source 
Bug: b/461656982
Change-Id: I0180194a037204c2eb3a23286ada0f956a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7166367
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
This commit is contained in:
Alex Ovsienko
2025-11-17 22:36:57 -08:00
committed by LUCI CQ
parent dac161882f
commit 565cc4ee35
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
post_build_ninja_summary.py
View File

@@ -329,6 +329,14 @@ def SummarizeEntries(entries, extra_step_types, elapsed_time_sorting):
def main():
# Single dashed go style flags get interpreted greedily by Python as short flags
# leading to -enable interpreted as -e and nable.
# To combat this, change it to double dash.
passed_args = sys.argv[1:].copy()
for i, arg in enumerate(passed_args):
if len(arg) > 2 and arg.startswith("-") and not arg.startswith("--"):
passed_args[i] = "-" + arg
log_file = ".ninja_log"
metrics_file = "siso_metrics.json"
parser = argparse.ArgumentParser()
@@ -347,7 +355,7 @@ def main():
)
parser.add_argument("--log-file",
help="specific ninja log file to analyze.")
args, _extra_args = parser.parse_known_args()
args, _ = parser.parse_known_args(passed_args)
if args.build_directory:
log_file = os.path.join(args.build_directory, log_file)
metrics_file = os.path.join(args.build_directory, metrics_file)