mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 18:51:29 +00:00
[git_cl] Fix creds_check new auth switch logic pt 2
I got greedy with the first fix, with the assumption that the flag enablement would not get rolled back. As it would be easier to not worry about this logic flip-flopping based on the default flag flip-flopping. Spoilers: it did get rolled back, so we end up with the new creds-check with the newauth flag defaulting to off. And this causes a UX problem because new users would get prompted to run creds-check to set up a gitcookies file, but the new creds-check logic doesn't do that. Based on our newfound experience, this should just follow the default value. There'll still be some friction whenever we flip-flop the default value, but that's kind of unavoidable. Change-Id: I0d81ed4123a8a9bced2fc4300214376cd3f1c9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6434738 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Allen Li <ayatane@chromium.org>
This commit is contained in:
Reference in New Issue
Block a user