InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Defaults stdin to VOID for capture and check_output()

Browse Source 
Since no output is user visible anyway, causing a hang with no clue about what
to type in.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6823091

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81302 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
maruel@chromium.org
2011-04-12 20:49:37 +00:00
parent 6c7723e796
commit 4a982271a7
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
subprocess2.py
View File

@@ -259,7 +259,10 @@ def capture(args, **kwargs):
- Discards returncode.
- Discards stderr. By default sets stderr=STDOUT.
- Blocks stdin by default since no output will be visible.
"""
if kwargs.get('stdin') is None:
kwargs['stdin'] = VOID
if kwargs.get('stdout') is None:
kwargs['stdout'] = PIPE
if kwargs.get('stderr') is None:
@@ -275,7 +278,10 @@ def check_output(args, **kwargs):
- Discards stderr. By default sets stderr=STDOUT.
- Throws if return code is not 0.
- Works even prior to python 2.7.
- Blocks stdin by default since no output will be visible.
"""
if kwargs.get('stdin') is None:
kwargs['stdin'] = VOID
if kwargs.get('stdout') is None:
kwargs['stdout'] = PIPE
if kwargs.get('stderr') is None: