InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

metrics: Add a mechanism to notify users when we want to collect additional metrics.

Browse Source 
When we change the version number in metrics_utils:

If the user is not a Googler, or has opted out explicitly, nothing happens
and we still don't collect metrics.

If we're collecting metrics from the user, we stop collecting metrics
and display a notice telling them what has changed.
That notice will be displayed ten times, after which we will
resume collecting metrics. A notice telling them we're collecting metrics
will still be displayed.

Bug: None
Change-Id: If1cc12b2fc06f0d6237714c4f182367b1afdf9fb
Reviewed-on: https://chromium-review.googlesource.com/c/1285395
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
This commit is contained in:
Edward Lemur
2018-10-18 02:08:06 +00:00
committed by Commit Bot
parent 3e002fb862
commit 488362624b
4 changed files with 243 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
metrics.README.md
View File

@@ -48,6 +48,13 @@ The metrics we're collecting are:
- Are you setting `use\_relative\_paths=True`?
- Are you using `recursedeps`?
## Why am I seeing this message *again*?
We might want to collect additional metrics, and if so we will ask you for
permission again.
Opting in or out explicitly will stop the messages from being displayed.
# How can I check if metrics are being collected?
You can run `gclient metrics` and it will report if you have opted in, out, or