InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

ninjalog_uploader: Collect all GN args except sensitive information

Browse Source 
Bug: 364971744
Fixed: 364971744
Change-Id: Ia09ba43f3cd12638923b3add458f2f32f9a03860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5836322
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
This commit is contained in:
Junji Watanabe
2024-09-06 08:09:07 +00:00
committed by LUCI CQ
parent 43691064b4
commit 4250face7b
2 changed files with 53 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/ninjalog_uploader_test.py
View File

@@ -41,7 +41,7 @@ class NinjalogUploaderTest(unittest.TestCase):
},
])), {
'is_component_build': 'true',
'host_cpu': '"x64"',
'host_cpu': 'x64',
})
self.assertEqual(
@@ -70,6 +70,35 @@ class NinjalogUploaderTest(unittest.TestCase):
'use_remoteexec': 'false'
})
# Do not include sensitive information.
with unittest.mock.patch('getpass.getuser', return_value='bob'):
args = ninjalog_uploader.ParseGNArgs(
json.dumps([
{
'current': {
'value': 'xyz'
},
'default': {
'value': ''
},
'name': 'google_api_key'
},
{
'current': {
'value': '/home/bob/bobo'
},
'default': {
'value': ''
},
'name': 'path_with_homedir'
},
]))
self.assertEqual(
args, {
'google_api_key': '<omitted>',
'path_with_homedir': '/home/$USER/bobo',
})
def test_get_ninjalog(self):
# No args => default to cwd.
self.assertEqual(ninjalog_uploader.GetNinjalog(['ninja']),