mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 18:51:29 +00:00
Rename caffeinate.run to .call and match the subprocess.call API.
I'm looking at caffeinating more long-running depot_tools commands on Mac, which use a variety of `subprocess` APIs; one implementation strategy I'm considering is to wrap more of them, including `subprocess.run`, but the most obvious name to wrap `subprocess.run` into is already taken! I think it makes the most sense to name the `caffeinate` function(s) after the `subprocess` call it wraps. The callers to other parts of `subprocess` use more of the features exposed by those APIs. For consistency, I am plumbing through more of `subprocess.call`'s identifiable behaviors here, too: * command-to-invoke parameter is named "args" * as explicitly checked in cpython's subprocess.py's `_posix_spawn`:77cb39e0c7/Lib/subprocess.py (L1816)also allow `str`, `bytes`, and `os.PathLike` for the type of `args`, converting the non-list-like types into a single-element list * use kwargs packing and unpacking to forward other parameters into `subprocess.call` kwargs packing does not provide perfect emulation as implemented:77cb39e0c7/Lib/subprocess.py (L386)`timeout` could be provided as a positional parameter. However, Python documents all subprocess.call parameters as keyword only: https://docs.python.org/3.12/library/subprocess.html#older-high-level-api ...specifically because they don't want to bother distinguishing between parameters "local" to a higher-level `subprocess` helper and those that get forwarded (via `**kwargs`) to the underlying `Popen`, so I think it is reasonable to follow their lead on that. Bug: 462507017 Change-Id: Ia520ced7f8188c23c38826d22ccf20a3c52ddfc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7181621 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Adam Norberg <norberg@google.com>
This commit is contained in:
4
siso.py
4
siso.py
@@ -311,14 +311,14 @@ def main(args, telemetry_cfg: Optional[build_telemetry.Config] = None):
|
||||
for siso_path in siso_paths:
|
||||
if siso_path and os.path.isfile(siso_path):
|
||||
check_outdir(subcmd, out_dir)
|
||||
return caffeinate.run([siso_path] + processed_args, env=env)
|
||||
return caffeinate.call([siso_path] + processed_args, env=env)
|
||||
print(
|
||||
'depot_tools/siso.py: Could not find siso in third_party/siso '
|
||||
'of the current project. Did you run gclient sync?',
|
||||
file=sys.stderr)
|
||||
return 1
|
||||
if siso_override_path:
|
||||
return caffeinate.run([siso_override_path] + args[1:], env=env)
|
||||
return caffeinate.call([siso_override_path] + args[1:], env=env)
|
||||
|
||||
print(
|
||||
'depot_tools/siso.py: Could not find .sisoenv under build/config/siso '
|
||||
|
||||
Reference in New Issue
Block a user