InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

[git cl split] Refactor splitting computation into separate function

Browse Source 
As part of a cleanup effort to make this script's major functions
less monolithic, this moves the part of SplitCL responsible for
computing a splitting into its own function.

Bug: 389069356
Change-Id: I1f8571d7bf27018da6c25263a05ad098e7d05836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6469473
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Devon Loehr <dloehr@google.com>
This commit is contained in:
Devon Loehr
2025-04-17 12:33:41 -07:00
committed by LUCI CQ
parent 463ce5a855
commit 3d62d2bdb5
1 changed files with 41 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
split_cl.py
View File

@@ -401,6 +401,45 @@ def PrintSummary(cl_infos, refactor_branch):
'results.)')
def ComputeSplitting(from_file: str, files: List[Tuple[str, str]],
target_range: Tuple[int, int], max_depth: int,
reviewers_override: List[str],
expect_owners_override: bool, cl) -> List[CLInfo]:
"""
Split the current CL into sub-CLs by partitioning the files and assigning
reviewers. The method used depends on the command-line arguments.
Arguments are the same as SplitCl, excecpt for the last:
cl: Changelist class instance, for calling owners methods
"""
author = git.run('config', 'user.email').strip() or None
if from_file:
# Load a precomputed splitting
cl_infos = LoadSplittingFromFile(from_file, files_on_disk=files)
elif target_range:
# Use the directory-based clustering algorithm
min_files, max_files = target_range
cl_infos = GroupFilesByDirectory(cl, author, expect_owners_override,
files, min_files, max_files)
else:
# Use the default algorithm
files_split_by_reviewers = SelectReviewersForFiles(
cl, author, files, max_depth)
cl_infos = CLInfoFromFilesAndOwnersDirectoriesDict(
files_split_by_reviewers)
# Note that we do this override even if the list is empty (indicating that
# the user requested CLs not be assigned to any reviewers).
if reviewers_override != None:
for info in cl_infos:
info.reviewers = set(reviewers_override)
return cl_infos
def SplitCl(description_file, comment_file, changelist, cmd_upload, dry_run,
summarize, reviewers_override, cq_dry_run, enable_auto_submit,
max_depth, topic, target_range, expect_owners_override, from_file,
@@ -441,7 +480,6 @@ def SplitCl(description_file, comment_file, changelist, cmd_upload, dry_run,
Emit('Cannot split an empty CL.')
return 1
author = git.run('config', 'user.email').strip() or None
refactor_branch = git.current_branch()
assert refactor_branch, "Can't run from detached branch."
refactor_branch_upstream = git.upstream(refactor_branch)
@@ -451,24 +489,8 @@ def SplitCl(description_file, comment_file, changelist, cmd_upload, dry_run,
if not dry_run and not CheckDescriptionBugLink(description):
return 0
if from_file:
cl_infos = LoadSplittingFromFile(from_file, files_on_disk=files)
elif target_range:
min_files, max_files = target_range
cl_infos = GroupFilesByDirectory(cl, author, expect_owners_override,
files, min_files, max_files)
else:
files_split_by_reviewers = SelectReviewersForFiles(
cl, author, files, max_depth)
cl_infos = CLInfoFromFilesAndOwnersDirectoriesDict(
files_split_by_reviewers)
# Note that we do this override even if the list is empty (indicating that
# the user requested CLs not be assigned to any reviewers).
if reviewers_override != None:
for info in cl_infos:
info.reviewers = set(reviewers_override)
cl_infos = ComputeSplitting(from_file, files, target_range, max_depth,
reviewers_override, expect_owners_override, cl)
if not dry_run:
PrintSummary(cl_infos, refactor_branch)