InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

owners_finder: Fix flaky tests.

Browse Source 
Sorting owners by score is non-deterministic, so sort by
name too.

Bug: 1009814
Change-Id: I93a9370a5852634b4bbb2768b9ebbb5b866348e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891665
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
This commit is contained in:
Edward Lemur
2019-11-04 21:14:09 +00:00
committed by Commit Bot
parent 94d6f48ba1
commit 288e358f3f
2 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
owners_finder.py
View File

@@ -161,9 +161,10 @@ class OwnersFinder(object):
self.selected_owners = set()
self.deselected_owners = set()
# Initialize owners queue, sort it by the score
self.owners_queue = list(sorted(self.owners_to_files.keys(),
key=lambda owner: self.owners_score[owner]))
# Initialize owners queue, sort it by the score and name
self.owners_queue = sorted(
self.owners_to_files.keys(),
key=lambda owner: (self.owners_score[owner], owner))
self.find_mandatory_owners()
def select_owner(self, owner, findMandatoryOwners=True):