InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make the downloaded tarfile a dotfile

Browse Source 
This is so that the third_party directories can gitignore the
downloaded tarfile. Currently theyre ignoring on *tar.gz

Bug: b/324418194
Change-Id: Id4aeeec366de3a0cec410de6ddd63369a3a4680a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5454165
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
This commit is contained in:
Stephanie Kim
2024-04-16 16:34:49 +00:00
committed by LUCI CQ
parent 22de5fb717
commit 188b08d7bf
2 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gclient.py
View File

@@ -2650,7 +2650,7 @@ class GcsDependency(Dependency):
# Directory of the extracted tarfile contents # Directory of the extracted tarfile contents
output_dir = os.path.join(root_dir, self.name.split(':')[0]) output_dir = os.path.join(root_dir, self.name.split(':')[0])
output_file = os.path.join(output_dir, self.output_file output_file = os.path.join(output_dir, self.output_file
or gcs_file_name) or f'.{gcs_file_name}')
# Remove any forward slashes and drop any extensions # Remove any forward slashes and drop any extensions
file_prefix = self.object_name.replace('/', '_').split('.')[0] file_prefix = self.object_name.replace('/', '_').split('.')[0]

4
tests/gclient_gcs_smoketest.py
View File

@@ -35,12 +35,8 @@ class GClientSmokeGcs(gclient_smoketest_base.GClientSmokeBase):
tree = self.mangle_git_tree(('repo_22@1', 'src')) tree = self.mangle_git_tree(('repo_22@1', 'src'))
tree.update({ tree.update({
'src/another_gcs_dep/llvmfile.tar.gz':
'tarfile',
'src/another_gcs_dep/extracted_dir/extracted_file': 'src/another_gcs_dep/extracted_dir/extracted_file':
'extracted text', 'extracted text',
'src/gcs_dep/deadbeef':
'tarfile',
'src/gcs_dep/extracted_dir/extracted_file': 'src/gcs_dep/extracted_dir/extracted_file':
'extracted text', 'extracted text',
'src/gcs_dep_with_output_file/clang-format-no-extract': 'src/gcs_dep_with_output_file/clang-format-no-extract':