InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

metadata: use os.walk to speedup metadata file discovery

Browse Source 
os.walk is more efficient than the current handwritten traversal.

Measured the time to scan reduced from 30s+ to 8s on p920 on
chromium/src.

`followlinks=True` is set to preserve behavior that os.path.isdir
returns True for symlink to directories, and the current traversal code
will descend into those.

Change-Id: I941eec9105a46d6538ca484fbb5249a75888e38a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5379945
Reviewed-by: Anne Redulla <aredulla@google.com>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
This commit is contained in:
Jiewei Qian
2024-03-20 05:29:24 +00:00
committed by LUCI CQ
parent 3155d7d074
commit 13d20527ff
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
metadata/discover.py
View File

@@ -28,11 +28,11 @@ def find_metadata_files(root: str) -> List[str]:
the root directory.
"""
metadata_files = []
for item in os.listdir(root):
full_path = os.path.join(root, item)
if is_metadata_file(item):
metadata_files.append(full_path)
elif os.path.isdir(full_path):
metadata_files.extend(find_metadata_files(full_path))
for (dirpath, _, filenames) in os.walk(root, followlinks=True):
for filename in filenames:
if is_metadata_file(filename):
full_path = os.path.join(root, dirpath, filename)
metadata_files.append(full_path)
return metadata_files