InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "siso: enable collector by default when metrics collection is on."

Browse Source 
This reverts commit a4318057fe.

Reason for revert: This seems to break builds with old Siso version.

Original change's description:
> siso: enable collector by default when metrics collection is on.
>
> Bug: b/455433899
> Change-Id: Icdc8f0fb516ed9782f85a935d733b9f26a6a6964
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7366313
> Commit-Queue: Alex Ovsienko <ovsienko@google.com>
> Reviewed-by: Junji Watanabe <jwata@google.com>

Bug: b/455433899
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I819a7271979e122d39a283dc376fc80fc741125b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7394760
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
This commit is contained in:
Junji Watanabe
2026-01-04 23:01:08 -08:00
committed by LUCI CQ
parent a4318057fe
commit 0847ade509
2 changed files with 13 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
siso.py
View File

@@ -256,7 +256,7 @@ def apply_metrics_labels(args: list[str]) -> list[str]:
def apply_telemetry_flags(args: list[str], env: dict[str, str]) -> list[str]:
telemetry_flags = [
"enable_cloud_monitoring", "enable_cloud_profiler",
"enable_cloud_trace", "enable_cloud_logging", "enable_collector"
"enable_cloud_trace", "enable_cloud_logging"
]
# Despite go.dev/issue/68312 being fixed, the issue is still reproducible
# for googlers. Due to this, the flag is still applied while the